This repository was archived by the owner on May 1, 2020. It is now read-only.
Provide the PathLocationStrategy in development mode#1339
Open
StefanRein wants to merge 2 commits intoionic-team:masterfrom
Open
Provide the PathLocationStrategy in development mode#1339StefanRein wants to merge 2 commits intoionic-team:masterfrom
StefanRein wants to merge 2 commits intoionic-team:masterfrom
Conversation
Contributor
Author
|
Also fixes this on local development: ionic-team/ionic-framework#10565 |
Contributor
Author
Contributor
Author
|
Ok discovered a resulting bug: He can not load: ion-dev.js and the ion-dev.css I'll look into this and commit a fix. |
Contributor
Author
|
Just needed to inject the dev logger script absolute now. |
Contributor
Author
|
I did experience an issue with |
|
This breaks proxies, because |
|
So...any word on a fix / new merge for path location support? Or is there any way to resolve that doesn't involve manually editing node_modules files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
With --pathlocationstrategy e.g.
npm run ionic-app-scripts serve --pathlocationstrategyyou can now use the PathLocationStrategy. This means you can refresh on a route like this: http://localhost:8100/dashboard/my-feature without a server error and loading the correct view of the route without the need to open http://localhost:8100/#/dashboard/my-feature with the HashLocationStrategy.Changes proposed in this pull request:
Fixes: #10565